fix(popup): fallback settings link open in prod (skeeditor-c4o9)#101
Draft
selfagency wants to merge 3 commits into
Draft
fix(popup): fallback settings link open in prod (skeeditor-c4o9)#101selfagency wants to merge 3 commits into
selfagency wants to merge 3 commits into
Conversation
|
❌ 1 Tests Failed:
View the full list of 1 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Fixes a production regression where clicking Settings in the popup could fail to open the options page.
What changed
src/popup/auth-popup.ts:browser.runtime.openOptionsPage()firstbrowser.tabs.create({ url: browser.runtime.getURL('options/index.html') })whenopenOptionsPagerejectstest/unit/popup/auth-popup.test.ts:openOptionsPagethrows.beans/skeeditor-c4o9--fix-popup-settings-link-not-opening-in-production.mdRoot cause
Popup settings navigation depended solely on
runtime.openOptionsPage(). In packaged production contexts this API can reject, leaving no fallback path.Test plan
test/unit/popup/auth-popup.test.ts→ pass (26/26)build:chrome)Bean
skeeditor-c4o9