build: override bundled libsemigroups install paths#1074
build: override bundled libsemigroups install paths#1074jengelh wants to merge 2 commits intosemigroups:stable-5.6from
Conversation
|
Thanks for the PR @jengelh, the "with-external-libsemigroups" is expected to fail at the moment, but not the Cygwin job, any chance you could adapt the changes in this PR so that the Cygwin job also passes? Thanks! |
|
cygwin x64 That does not look like dll related things (or if, it's not very indicative). |
|
It states just above this that the kernel module isn't compiled, I guess it is unable to find the DLL, which would be related to your changes I think |
6f2259f to
3255d17
Compare
|
Just rebased onto |
|
@jengelh the cygwin job still fails, I'm afraid. @Joseph-Edwards any chance you can take a look at this in the meeting tomorrow? |
Will do |
3255d17 to
8e30b9d
Compare
|
@jengelh the changes in my commit here fix the ci, can you please confirm whether or not the changes we've reverted were not essential to your pr? I.e. does the pr as given resolve the issue? |
Fixes: #1073