build: use libsemigroups/hpcombi.mk not m4/ax_check_hpcombi#1154
Open
james-d-mitchell wants to merge 9 commits intosemigroups:mainfrom
Open
build: use libsemigroups/hpcombi.mk not m4/ax_check_hpcombi#1154james-d-mitchell wants to merge 9 commits intosemigroups:mainfrom
libsemigroups/hpcombi.mk not m4/ax_check_hpcombi#1154james-d-mitchell wants to merge 9 commits intosemigroups:mainfrom
Conversation
james-d-mitchell
force-pushed
the
use-hpcombi-mk-file
branch
2 times, most recently
from
78a0a73 to
3131778
Compare
Collaborator
Author
|
This will fail until libsemigroups/libsemigroups#926 is merged, released, and we bump the version of libsemigroups required here. |
Namely if any of the non-standard libsemigroups flags from: https://libsemigroups.github.io/libsemigroups/md_install.html and --with-external-libsemigroups are set. This avoids the situation in: libsemigroups/libsemigroups#910 where the flags in the external libsemigroups and the flags given to the Semigroups GAP package's configure are not the same.
james-d-mitchell
force-pushed
the
use-hpcombi-mk-file
branch
from
3131778 to
993b438
Compare
james-d-mitchell
changed the title
libsemigroups/hpcombi.mk not m4/ax_check_hpcombi
This commit adds a job that checks ./configure passes/fails as expected when run with --with-external-libsemigroups plus some additional flags. Most of these new flags are libsemigroups specific (such as --enable-hpcombi), and in such cases the call to ./configure should fail. With other flags such as --enable-debug, configure should pass.
Collaborator
|
@james-d-mitchell, new CI job has now been implemented in 60e6db5 and seems to be running as expected. |
Collaborator
Author
|
Some of the ci is failing because conda hasn't yet picked up the v3.5.4 release, will try again in 48 hours. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.