Skip to content

UIK-3093/feedback-rating-a11y-issue #2690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Valeria-Zimnitskaya merged 10 commits into from
Feb 4, 2026
Merged

UIK-3093/feedback-rating-a11y-issue #2690

Valeria-Zimnitskaya merged 10 commits into from
Feb 4, 2026
+9 −1

Conversation

@slizhevskyv-semrush
Copy link
Contributor

@slizhevskyv-semrush slizhevskyv-semrush commented Jan 30, 2026

Changelog

@semcore/modal

Fixed

  • Added conditional logic for displaying aria-label based on aria-labelledby prop.

Motivation and Context

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Nice improve.

Checklist:

  • I have updated the documentation accordingly.
  • I have added new tests on added of fixed functionality.

@slizhevskyv-semrush slizhevskyv-semrush changed the title UIK-3093/modal-a11y-issue UIK-3093/feedback-rating-a11y-issue Jan 30, 2026
sheila-semrush
sheila-semrush approved these changes Feb 2, 2026
View reviewed changes
Copy link
Contributor

@sheila-semrush sheila-semrush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as expected!

@Valeria-Zimnitskaya Valeria-Zimnitskaya merged commit c275d9f into release/v16 Feb 4, 2026
12 of 13 checks passed
@Valeria-Zimnitskaya Valeria-Zimnitskaya deleted the UIK-3093/modal-a11y-issue-w-aria-label branch February 4, 2026 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ilyabrower ilyabrower ilyabrower approved these changes

@sheila-semrush sheila-semrush sheila-semrush approved these changes

@Valeria-Zimnitskaya Valeria-Zimnitskaya Valeria-Zimnitskaya approved these changes

Assignees

No one assigned

Labels

feedback-form

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@slizhevskyv-semrush @ilyabrower @sheila-semrush @Valeria-Zimnitskaya