Skip to content

fix(ci): add changelog entry and improve workflow skip logic#44

Closed
Copilot wants to merge 3 commits intomainfrom
copilot/sub-pr-43
Closed

fix(ci): add changelog entry and improve workflow skip logic#44
Copilot wants to merge 3 commits intomainfrom
copilot/sub-pr-43

Conversation

Copy link

Copilot AI commented Feb 16, 2026

Description

Addresses review feedback on the Claude Code review skip logic. Fixed missing CHANGELOG entry (CL-1 violation) and workflow race condition.

Changes

  • CHANGELOG.md: Added entry for workflow skip feature with commit reference link per CL-1/CL-4
  • Race condition fix: Made "Minimize previous review comments" step conditional—now only runs when NOT skipping to prevent minimizing comments when no new review is posted
  • Improved skip check: Added explicit skip=false output for clarity
  • Better skip comment: Removed @copilot mention (no guarantee of invocation), clearer technical explanation

Test Plan

  • Verified CHANGELOG entry follows Keep a Changelog format with proper commit reference
  • Reviewed workflow conditional logic: minimize step now properly gated by steps.check.outputs.skip != 'true'
  • Confirmed this PR itself will trigger the skip path (self-validating)

Checklist

  • Commit messages follow Conventional Commits
  • CHANGELOG.md updated (if user-facing change)
  • Exported functions have doc comments

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

danielewood and others added 2 commits February 16, 2026 13:37
The OAuth token exchange validates that the workflow file matches
main exactly, so PRs that modify claude-code-review.yml always fail.
Add an early check that detects this and skips the review gracefully
instead of burning runner time on an inevitable 401.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Add missing CHANGELOG.md entry for workflow skip feature (CL-1)
- Make "Minimize previous review comments" step conditional to avoid race condition
- Add explicit skip=false to check step for clarity
- Improve skip comment message (remove @copilot mention, clearer explanation)
- Add commit reference link to CHANGELOG.md

Co-authored-by: danielewood <23008560+danielewood@users.noreply.github.com>
Copilot AI changed the title [WIP] Add early check to skip claude review on workflow file changes fix(ci): add changelog entry and improve workflow skip logic Feb 16, 2026
Copilot AI requested a review from danielewood February 16, 2026 18:44
@danielewood danielewood force-pushed the ci/skip-review-on-workflow-change branch 4 times, most recently from bac26fd to a698943 Compare February 16, 2026 19:10
Base automatically changed from ci/skip-review-on-workflow-change to main February 16, 2026 19:17
@danielewood
Copy link
Collaborator

Closing — parent PR #43 was already merged and these changes are superseded by #45.

@danielewood danielewood deleted the copilot/sub-pr-43 branch February 18, 2026 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants