Add methods for appending Buildable objects to buffer.#1
Merged
Conversation
Adds method append() which can be used to append a result of building a Buildable to the end of buffer.
This can be used when implementing Buildable and want to indicate caller that some elements of the data were invalid and could not be built.
oherrala
approved these changes
Apr 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds two methods,
append()andappend_all()toBuilder.append()allows to add aBuildableto the end of buffer andappend_all()can be used to append a slice ofBuildables to the end of the buffer. Both methods will call thebuild()method of buildable to write data to buffer. If error occurs while appending data, the index of buffer is reset back to where it was whenappend()orappend_all()was called.Also add a new error type
Error::InvalidDatawhich allows thebuild()method ofBuildableto signal that data was invalid and could not be written into buffer.