Issue #149: Extracted email messages to templates. Fixed some bugs, cleaned up some code.#156
Open
lilliputten wants to merge 8 commits intomainfrom
Open
Issue #149: Extracted email messages to templates. Fixed some bugs, cleaned up some code.#156lilliputten wants to merge 8 commits intomainfrom
lilliputten wants to merge 8 commits intomainfrom
Conversation
…sing request parameter to message generation code, added templates for payment invoice, added email helpers.
…list from constants instead of literal list, with missed 'USD' value).
… invoice event. Cleaned up code.
cmutel
reviewed
Apr 10, 2024
| text = render_to_string( | ||
| template_name=email_template, | ||
| context=context, | ||
| request=request, |
Contributor
There was a problem hiding this comment.
You had to make a lot of changes elsewhere to get the request here, but I don't understand why it is needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Views of sending messages:
Overall changes:
billingtopayment.