Rebase by merging the master branch to fix compatibility issues with probe-rs#3
Open
Mimoja wants to merge 6 commits into
Open
Rebase by merging the master branch to fix compatibility issues with probe-rs#3Mimoja wants to merge 6 commits into
Mimoja wants to merge 6 commits into
Conversation
- Fix obvious bug with multi-packet pending response lengths The length needs to go along with the data buf, not a random global - Move to async notifications instead of polling or hacky suspend/resume For a tick interval ~= the time taken to transmit one full bulk packet, you could get a NAK and flow-controlled if usb_thread went to sleep - Remove redundant memcpys and unused variables - Hack the reported DAP packet count to avoid bulk-OUT/NAK conditions as much as possible
Mimoja
changed the title
Author
|
Build and use tested with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The probe-rs tool fails to talk to a rp2040 via the zero due to the dap fixes missing. Therefore rebase with a merge commit.
Commits which are added with this merge: