Move custom schema documentation to pipeline-schema overview#1139
Move custom schema documentation to pipeline-schema overview#1139llewellyn-sl wants to merge 9 commits intomasterfrom
Conversation
Updates pipeline versioning documentation with GA release features: - Add nested parameter support for track_changes at leaf node level - Update terminology from "checksum" to "hash" throughout - Add versionName and versionHash search keywords - Document shared pipeline publishing restrictions - Add pipeline optimization integration section Related to PLAT-4471 (Versioning GA QA Testing) - PLAT-3576: Version search with additional keywords - PLAT-4051: Version hash terminology update - PLAT-3877: Nested schema property support - PLAT-3501: Pipeline optimization integration - PLAT-4090: Shared pipeline publishing behavior Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
…nges - Add custom schema documentation to Cloud and Enterprise 25.3 versioning pages - Remove preview status from Enterprise 25.3 (feature now GA) - Add commit ID pinning recommendation for Enterprise 25.3 - Update shared pipeline editing notes to clarify workspace restrictions - Update pipeline optimization section for non-default version clarity - Remove versioning page from Cloud sidebar (releasing Feb 19) Addresses PR review comments from PLAT-3570 custom schema feature. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
- Add "Define pipeline schema" section to pipeline-schema/overview.md - Document all three schema options: Repository default, Repository path, and Seqera Platform schema - Include detailed instructions for Seqera Platform schema option - Add note about unique schema id field requirement - Remove Custom schema section from pipelines/versioning.md - Update versioning.md references to point to new location - Apply changes to both Cloud and Enterprise v25.3 docs Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
✅ Deploy Preview for seqera-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
@claude please review |
|
Claude finished @llewellyn-sl's task —— View job Reviewing PR: Move custom schema documentation
Review SummaryThis PR successfully restructures the custom schema documentation with good improvements. The changes are well-executed and improve the organization of the documentation. ✅ Positive Changes
🔍 Minor Issues Foundplatform-cloud/docs/pipelines/versioning.md:8-12
Content consistency
📝 Documentation QualityThe migrated content maintains high quality:
🔗 Cross-References Status
Overall AssessmentThis is a well-executed documentation restructuring that improves content organization and adds valuable detail. The changes enhance user experience by consolidating schema-related information in the appropriate location. Recommendation: ✅ Approved - Consider adding the missing tip callout to Cloud versioning.md for consistency with Enterprise version. |
Signed-off-by: Llewellyn vd Berg <113503285+llewellyn-sl@users.noreply.github.com>
|
@claude I resolved conflicts, that should take care of the missing tip you highlighted in your previous review. Please review again |
|
Claude finished @llewellyn-sl's task —— View job Re-reviewing PR after conflict resolution
✅ Issues ResolvedGreat work! The conflict resolution has successfully addressed the content inconsistency issue I identified in my previous review: Cloud vs Enterprise versioning.md consistency:
✅ Continued StrengthsAll the positive aspects from my previous review remain intact:
🔍 Current State AnalysisCross-reference verification:
Content quality:
Final AssessmentRecommendation: ✅ Approved - All previous issues have been resolved. The conflict resolution successfully addressed the content inconsistency, and the PR now provides a clean, well-structured documentation improvement that enhances user experience by consolidating schema-related information in the logical location. The documentation restructuring is complete and ready for merge. |
Updates versioning documentation to clarify that resource labels are excluded from triggering new pipeline versions, alongside name, image, description, and labels. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
|
|
||
| Seqera maintains a history of all draft and published versions, providing an audit trail of pipeline evolution. | ||
|
|
||
| #### Custom schema |
There was a problem hiding this comment.
This section needs updating to reflect the new usage of 'Seqera Platform schema' rather than custom schema. Some of this can also be trimmed out as it replicate what is precent in the pipeline-schema/overview.md. We should link to that from here. Same goes for cloud docs obvs.
| 2. **Repository path**: Use a schema at a specific path in the repository. | ||
| 3. **Seqera Platform schema**: Use a Nextflow JSON schema stored in Seqera Platform (overrides repository). | ||
|
|
||
| The selected schema controls which pipeline parameters are exposed in the launch form. This allows you to restrict the parameters visible to launch users, simplifying the launch experience and preventing modification of parameters that should remain fixed. |
There was a problem hiding this comment.
'prevent' is a strong word here. The user is still able to edit the config view directly. The launch form defined by the schema can hide parameters which the pipeline maintain wishes not to be fiddled with, but it cannot prevent direct specification in the config view. Actually, let me double check that.
There was a problem hiding this comment.
Actually this is correct, it's possible to hide a parameter, set a default and a validation which only validates the default.
| 5. Select **Add** or **Save** to create a new draft version with the Platform schema | ||
|
|
||
| :::note | ||
| The schema `id` field must be unique. If you're pasting pipeline schema contents from an existing pipeline schema file, ensure you update the `id` field to a unique value. |
There was a problem hiding this comment.
removal of the id is also a valid fix.
|
|
||
| Users with [Maintain or higher](../orgs-and-teams/roles.md) permissions can upload a custom `nextflow_schema.json` file directly to Seqera Platform. When you upload a Platform schema: | ||
|
|
||
| - The schema content is validated to ensure it's a valid JSON schema |
There was a problem hiding this comment.
This list, the one below, and the next two should have fullstops at the end of the items. Thanks!
Summary
pipelines/versioning.mdtopipeline-schema/overview.mdidfield requirementTest plan
🤖 Generated with Claude Code