Rework work queue around invocation-scoped leases#99
Draft
pditommaso wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lib-data-workqueueconcurrency invocation-scoped: a permit and thread are held only while one handler call executeslib-data-workqueue-redisat-least-once and backed only by Redis Stream data structureslib-cmd-queue-rediswith renewable command-attempt guards, atomic stale-writer fencing, terminal-state checks, and stable command IDsSUBMITTINGso interrupted external submission is retried with the same idempotency keyFixes #96.
Design and compatibility
This intentionally changes the
WorkQueueSPI by separating new delivery (receiveNew) from expired PEL reclaim (reclaim).concurrency()now limits active handler invocations rather than admitted/live task lifecycles.lib-data-workqueueguarantees at-least-once delivery. It does not claim exactly-once side effects.lib-cmd-queue-redisadds the state/ownership layer needed for near-exactly-once processing under normal operation. Command handlers must usecommand.id()as the idempotency key for external side effects because no local protocol can make an uncooperative remote API exactly once across process failure.SUBMITTINGis a new serialized command status and therefore needs consideration during mixed-version rollout.Adversarial review
The review specifically exercised:
max-processing-time, verifying no overlapping callTwo races found during review were corrected:
Validation
The suite includes unit tests and Testcontainers-backed Redis end-to-end validation.