feat(cli): Add experimental flags#101
Merged
misonijnik merged 6 commits intomainfrom Apr 22, 2026
Merged
Conversation
Fix silent MarkHidden on the scan command: flags registered with scanCmd.Flags() were being hidden via scanCmd.PersistentFlags(), whose Lookup could not find them, so the MarkHidden error was swallowed and --code-flow-limit, --approximations-config, --dataflow-approximations, --track-external-methods, and --debug-fact-reachability-sarif all leaked into the default help output. Separate analyzer domain logic from the cmd layer: - internal/analyzer/exit.go owns exit-code constants, ExitMessage, Error type, and Classify (no I/O); scan.go handles presentation - java.DeriveJavacPath moves to internal/utils/java/detection.go and is now Windows-aware - utils.ExtractZipPrefix + copyZipEntry consolidate zip-prefix extraction with deferred cleanup, removing four repeated os.RemoveAll calls - compile_approximations.go is split into collectJavaSources, resolveJavacPath, buildApproxClasspath, runJavac
misonijnik
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.