GitHub Action to ensure this project builds successfully#26
Open
cclauss wants to merge 8 commits intoserenadeai:masterfrom
Open
GitHub Action to ensure this project builds successfully#26cclauss wants to merge 8 commits intoserenadeai:masterfrom
cclauss wants to merge 8 commits intoserenadeai:masterfrom
Conversation
Updated Node.js versions in CI matrix and added Linux-specific dependencies.
Updated Node.js versions in CI matrix and commented out test runs.
Added libxtst-dev to the installation step and commented out the state.js test.
Add installation of node-addon-api in CI workflow
Exclude the latest Node.js version on Ubuntu from the CI matrix.
Removed installation of node-addon-api from CI workflow.
Contributor
|
This package is actually unmaintained (I'm not a maintainer), although I will fork it if it becomes absolutely necessary. That said - I'm not 100% sure that I understand the intention of this. In the title, you say running |
Author
% |
cclauss
changed the title
yarn test
Contributor
|
Got it. I appreciate you wanting to improve reliability in this project! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test results: https://github.com/cclauss/driver/actions
https://docs.github.com/en/actions/tutorials/build-and-test-code/nodejs#example-using-yarn
@tmacwill @s-h-a-d-o-w your reviews, please.