Fix: Build failures on M1 Mac and C-only libraries, memory leak#18
Fix: Build failures on M1 Mac and C-only libraries, memory leak#18gharris1727 wants to merge 3 commits intoserenadeai:masterfrom
Conversation
Signed-off-by: Greg Harris <greg.harris@aiven.io>
Signed-off-by: Greg Harris <greg.harris@aiven.io>
Signed-off-by: Greg Harris <greg.harris@aiven.io>
|
I'm not directly impacted by 1 (though it seems like it would be good to address), but I also noticed and was affected by 3 [1]. I didn't look closely at 2, so I don't have an informed opinion about it, but on the surface it seems reasonable to me. @tmacwill Would you consider looking over this PR? [1] In my case the build didn't fail, but I had an error during execution. |
|
I can confirm that building is currently broken on M1 and this PR makes it work, is it getting merged anytime soon? |
|
On a kind of related note, tree-sitter-python's scanner has been rewritten in C. IIUC, if this or similar PR is not merged, newer versions of tree-sitter-python will not be usable from java-tree-sitter. It was mentioned here that there is a fork that may have appropriate fixes applied though. |
This contains three separate fixes that are combined into one PR, let me know if you'd prefer them separated out.
aarch64toarm64to compensate. When thedylibwas built, it became stale and would not get cleaned, and wouldn't get picked up by the tests, so I fixed those as well.cppflag is set to false, despite the JNI shim itself making use of CPP new/delete calls. To fix this, I removed the option for c-only compilation, effectively setting cpp to always true.