ScanAll method at FullPrimaryKey, HashPrimaryKey#11
Open
extJo wants to merge 7 commits intoserverless-seoul:masterfrom
Open
ScanAll method at FullPrimaryKey, HashPrimaryKey#11extJo wants to merge 7 commits intoserverless-seoul:masterfrom
extJo wants to merge 7 commits intoserverless-seoul:masterfrom
Conversation
breath103
requested changes
Jul 8, 2020
breath103
approved these changes
Jul 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BACKEND-STORY_ID One-sentence summary of changes
Is it a breaking change?: NO
Why did you make these changes?
When scan all records, for iteration, code is so dirty.
So, i think scanAll support at ORM layer.
What's changed in these changes?
I added
scanAllmethod toFullPrimaryKeyclass.I added
scanAllmethod toHashPrimaryKeyclass.What do you especially want to get reviewed?
Is parameter 'limit' of scanAll method needed?.
Is there any other comments that every teammate should know?
nope.
Submission Type
All Submissions
New Features