Skip to content

Optimization: Avoid iterators #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SergeiPavlov merged 1 commit into from
Mar 24, 2026
Merged

Optimization: Avoid iterators #463

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions Orm/Xtensive.Orm/Orm/Building/Builders/DatabaseDependencyBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,9 +136,8 @@ private DatabaseConfiguration FindConfiguration(string db)

private void Visit(string database)
{
if (visited.Contains(database))
if (!visited.Add(database))
return;
visited.Add(database);
var references = referenceRegistry.Keys
.Where(r => r.OwnerDatabase==database);
foreach (var reference in references) {
Expand Down
2 changes: 1 addition & 1 deletion Orm/Xtensive.Orm/Orm/Linq/Expressions/Visitors/IncludeFilterMappingGatherer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ public static void Gather(Expression filterExpression, Expression filterDataTupl
{
var visitor = new IncludeFilterMappingGatherer(filterDataTuple, filteredTuple, mapping);
_ = visitor.Visit(filterExpression);
if (mapping.Contains(null))
if (mapping.IndexOf(null) >= 0)
throw Exceptions.InternalError("Failed to gather mappings for IncludeProvider", OrmLog.Instance);
}

Expand Down
Loading