Skip to content

server: Raise client_max_body_size for intermittent-tracker#135

Merged
delan merged 3 commits into
servo:mainfrom
kkoyung:raise-client-max-body-size
May 26, 2026
Merged

server: Raise client_max_body_size for intermittent-tracker#135
delan merged 3 commits into
servo:mainfrom
kkoyung:raise-client-max-body-size

Conversation

@kkoyung

@kkoyung kkoyung commented May 26, 2026

Copy link
Copy Markdown
Member

WPT Import https://github.com/servo/servo/actions/runs/26348192526 is currently blocked because the intermittent-tracker server rejected queries to https://intermittent-tracker.servo.org/dashboard/query with "HTTP Error 413: Request Entity Too Large" when the request body is too large.

Attempt to unblock it by raising the client_max_body_size setting of nginx for intermittent-tracker servers to 20m. (The default value of global client_max_body_size setting of nginx in NixOS is 10m, instead of 1m in standalone nginx.)

Remark: There was a discussion on similar issue, before migrating CI servers to NixOS. servo/servo#31845

WPT Import https://github.com/servo/servo/actions/runs/26348192526 is
currently blocked because the intermittent-tracker server rejected
queries to https://intermittent-tracker.servo.org/dashboard/query with
"HTTP Error 413: Request Entity Too Large" when the request body is too
large.

Attempt to unblock it by raising the `client_max_body_size` setting of
nginx for intermittent-tracker servers to `20m`. (The default value of
global `client_max_body_size` setting of nginx in NixOS is `10m`,
instead of `1m` in standalone nginx.)

Remark: There was a discussion on similar issue, before migrating CI
servers to NixOS. servo/servo#31845

Signed-off-by: Kingsley Yung <kingsley@kkoyung.dev>
@kkoyung kkoyung requested a review from delan as a code owner May 26, 2026 05:25

@delan delan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix :)

Comment thread server/nixos/configuration.nix Outdated
@delan

delan commented May 26, 2026

Copy link
Copy Markdown
Member

deploying:

$ cd server/nixos
$ ./do deploy ci0
$ for i in {1..4}; do ./do deploy ci$i & done

@delan delan self-requested a review May 26, 2026 06:42
@delan

delan commented May 26, 2026

Copy link
Copy Markdown
Member

putting it in commonHttpConfig does not work:

May 26 06:46:48 ci0 systemd[1]: Starting Nginx Web Server...
May 26 06:46:48 ci0 nginx-pre-start[3726329]: nginx: [emerg] "client_max_body_size" directive is duplicate in /nix/store/01qqxa245b15xp28fxfhvsl5x92wlyqb-nginx.conf:33
May 26 06:46:48 ci0 nginx-pre-start[3726329]: nginx: configuration file /nix/store/01qqxa245b15xp28fxfhvsl5x92wlyqb-nginx.conf test failed
May 26 06:46:48 ci0 systemd[1]: nginx.service: Control process exited, code=exited, status=1/FAILURE
May 26 06:46:48 ci0 systemd[1]: nginx.service: Failed with result 'exit-code'.
May 26 06:46:48 ci0 systemd[1]: Failed to start Nginx Web Server.

@delan

delan commented May 26, 2026

Copy link
Copy Markdown
Member

d2948d4 fixes that. deploying:

$ cd server/nixos
$ ./do deploy ci{0..4}

@delan

delan commented May 26, 2026

Copy link
Copy Markdown
Member

all good, per zulip :)

@delan delan merged commit 74e9e57 into servo:main May 26, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants