ohos: Remove catch in sign script so that the error is propogated and not ignored#139
Merged
Merged
Conversation
Signed-off-by: Jane <5373400+janeoa@users.noreply.github.com>
Narfinger
approved these changes
Jun 10, 2026
Narfinger
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Thanks for the cleanup!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the current state, when running
uv run main.py ~/path-to-build-profile.json5from the
docker/runner/signing-util, there is a case when it fails:When the
build-profile.json5is valid, butmaterialdir is not present, the script will still print out "File sign.sh written" and the file will actually be written. But instead of expected contents, the file would have anode error messageinside it. Because the python doesbut the JS:
... } catch (e) { console.log(e); }so the current PR just removes the catch, so that the error can propagate and now python returns full error message into the stdout and does not produce the
sign.sh