Add linux style path parsing for build_profile.json5#140
Open
janeoa wants to merge 2 commits into
Open
Conversation
Signed-off-by: Jane <5373400+janeoa@users.noreply.github.com>
Contributor
|
I don't think we need tests for this script. |
Narfinger
suggested changes
Jun 10, 2026
Signed-off-by: Jane <5373400+janeoa@users.noreply.github.com>
Narfinger
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, in the
docker/runner/signing-utilwhen you douv run main.py ~/path-to-build-profile.json5it expects the
build-profile.json5to have windows styleC:\\path\to\certs, which I did not expect. So when I would run themain.pyit would sayFile sign.sh writtenand create thesign.shbutkey_base_namewould be set to/home/username1instead of actual value.This PR tries to unify the parser by converting windows style to linux style and then parsing the linux style path.
I also included a test just in case, which can be run from
docker/runner/signing-utilusinguv run python -m unittest