Skip to content

Add linux style path parsing for build_profile.json5#140

Open
janeoa wants to merge 2 commits into
servo:mainfrom
janeoa:fix-signing-util-path-parsing
Open

Add linux style path parsing for build_profile.json5#140
janeoa wants to merge 2 commits into
servo:mainfrom
janeoa:fix-signing-util-path-parsing

Conversation

@janeoa

@janeoa janeoa commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Currently, in the docker/runner/signing-util when you do

uv run main.py ~/path-to-build-profile.json5

it expects the build-profile.json5 to have windows style C:\\path\to\certs, which I did not expect. So when I would run the main.py it would say File sign.sh written and create the sign.sh but key_base_name would be set to /home/username1 instead of actual value.

This PR tries to unify the parser by converting windows style to linux style and then parsing the linux style path.
I also included a test just in case, which can be run from docker/runner/signing-util using uv run python -m unittest

Signed-off-by: Jane <5373400+janeoa@users.noreply.github.com>
@janeoa janeoa requested a review from jschwe as a code owner June 10, 2026 13:19
@Narfinger

Copy link
Copy Markdown
Contributor

I don't think we need tests for this script.

Comment thread docker/runner/signing-util/main.py Outdated
Signed-off-by: Jane <5373400+janeoa@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants