Use BTreeMap rather than HashMap in markup5ever build script#574
Merged
nicoburns merged 1 commit intoservo:mainfrom Feb 20, 2025
Merged
Use BTreeMap rather than HashMap in markup5ever build script#574nicoburns merged 1 commit intoservo:mainfrom
BTreeMap rather than HashMap in markup5ever build script#574nicoburns merged 1 commit intoservo:mainfrom
Conversation
|
Unfortunately, it did not help. |
Contributor
|
I'm about 80% certain this + servo/string-cache#290 will close this issue.
|
Signed-off-by: Nico Burns <nico@nicoburns.com>
nicoburns
force-pushed
the
build-with-btree-map
branch
from
f51fc46 to
23c2f55
Compare
jdm
approved these changes
Feb 20, 2025
|
In my tests, this change was not needed. Only the string-chache one. |
Contributor
Author
|
I think we might as well have this. It can't hurt. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Speculative fix for #573
@bmwiedemann could you test and see whether this PR fixes your issue?