Use NonNull in place of *const (v2)#334
Merged
Conversation
mbrubeck
requested changes
Jan 15, 2024
Collaborator
mbrubeck
left a comment
mbrubeck
left a comment
There was a problem hiding this comment.
Thanks again! Added one minor request.
src/lib.rs
Outdated
| copy_nonoverlapping(ptr.as_ptr(), self.raw.as_mut_ptr_inline(), len); | ||
| drop(DropDealloc { | ||
| ptr: NonNull::new_unchecked(ptr as *mut u8), | ||
| ptr: NonNull::new_unchecked(ptr.as_ptr() as *mut u8), |
matzemathics
force-pushed
the
use-non-null-v2
branch
from
528d04c to
9717c5b
Compare
mbrubeck
approved these changes
Jan 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of #171. While it (at least currently) does not improve the size of objects in any case I could come up with, it still feels a lot more appropriate to use, because it cleanly communicates the requirements it already had: it is covariant and never null.