feat: default to PGlite for type generation#12
Open
joaogscardoso82-max wants to merge 1 commit into
Open
Conversation
`pgstrap generate` now uses PGlite by default, so a running Postgres instance is no longer required for type generation. Users who need a real Postgres connection can pass `--no-pglite`. Closes seveibar#2 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pgstrap generatenow uses PGlite by default, removing the requirement for a running Postgres instance during type generation.Changes
src/cli.ts: Changed--pgliteflag default fromfalsetotrueREADME.md: Updated docs to reflect the new default and document--no-pglitefor users who need a real Postgres connectionWhy
Running
bun run db:generate(ornpm run db:generate) currently fails unless the user has Postgres running in the background. Since PGlite support is already fully implemented and tested, making it the default removes this friction. Users who need a real Postgres connection can opt in with--no-pglite.Testing
The existing
tests/generate.pglite.test.tsalready covers this exact code path. No new tests needed since we're only changing which path is the default.Closes #2
@algora-pbc /claim #2