init: default db:generate to --pglite#24
Open
js360000 wants to merge 1 commit into
Open
Conversation
Fixes seveibar#2 Scaffolded db:generate previously ran 'pgstrap generate', which requires a running Postgres instance. Running 'bun run db:generate' on a fresh project would fail with a connection error. Default to '--pglite' so type generation works out of the box against an in-memory PGlite instance. Users who need to generate against a real Postgres (e.g. via DATABASE_URL) can drop the flag from the scaffolded script. - src/init.ts: scaffold db:generate with --pglite - tests/init.test.ts: assert the new default and add a regression test - README.md: document the new default /claim seveibar#2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
init: default db:generate to --pglite
Scaffolded db:generate previously ran 'pgstrap generate', which requires
a running Postgres instance. Running 'bun run db:generate' on a fresh
project would fail with a connection error.
Default to '--pglite' so type generation works out of the box against an
in-memory PGlite instance. Users who need to generate against a real
Postgres (e.g. via DATABASE_URL) can drop the flag from the scaffolded
script.
Diff
Claim
/claim #2