add StreamingIteratorMut::flatten#27
Merged
cuviper merged 8 commits intosfackler:masterfrom Sep 8, 2022
Merged
Conversation
cuviper
requested changes
Aug 22, 2022
Collaborator
cuviper
left a comment
cuviper
left a comment
There was a problem hiding this comment.
This is clever to build Flatten on StreamingIteratorMut! That gives it a kind of superpower that the regular FlatMap can't match with just identity, since this can iterate the borrowed inner iterator in-place.
Contributor
Author
|
Thanks for the review. I agree with your suggestions. Currently I am on vacation but I will follow up on this once I get back. |
Contributor
Author
|
I opened #28 for the clippy warnings |
cuviper
reviewed
Sep 6, 2022
cuviper
approved these changes
Sep 7, 2022
Collaborator
cuviper
left a comment
cuviper
left a comment
There was a problem hiding this comment.
I rebased and added a couple more fixes for the things below. If that looks good to you, then I think we're all set!
Contributor
Author
|
looks good to me :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StreamingIteratorMut::flattenFlattenimpl StreamingIterator for Flattenimpl StreamingIteratorMut for Flatten