Added support to new Direct Messages Events endpoint (rebased)#919
Merged
sferik merged 7 commits intosferik:masterfrom Jun 11, 2018
Merged
Added support to new Direct Messages Events endpoint (rebased)#919sferik merged 7 commits intosferik:masterfrom
sferik merged 7 commits intosferik:masterfrom
Conversation
added 7 commits
April 26, 2018 16:31
Contributor
|
Awesome @FabienChaynes!!! Thanks |
|
@danicuki @FabienChaynes, I need these changes to be incorporated in current project. Thanks for making these changes. Do you guys have any idea when these changes were going to be merged in master (or) Do we have any specific person to whom,I should request to merge these changes. |
Contributor
Author
|
@abhishek1203 all the conversation about this is present in this PR and in #847, so no we don't have more information 😕 |
Owner
|
Thanks! I’ll push out a new release shortly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@danicuki: Thanks for your work on this! As @sferik asked on #847 I rebased master and resolved the conflict, I hope you don't mind.
It'd be awesome to have this merged alongside #900 to be able to fully use the new DM API which will replace the one currently used by the gem.
If any work is needed, I'd be glad to help 🙂