This repository was archived by the owner on Oct 20, 2025. It is now read-only.
Reduced memory requirement for filterPeaks#71
Closed
piplus2 wants to merge 2 commits intosgibb:masterfrom
Closed
Conversation
Contributor
Author
|
Improved the performances: using the dataset fiedler2009subset default: new ver: |
Codecov Report
@@ Coverage Diff @@
## master #71 +/- ##
==========================================
- Coverage 88.44% 87.63% -0.82%
==========================================
Files 81 81
Lines 1411 1439 +28
==========================================
+ Hits 1248 1261 +13
- Misses 163 178 +15
Continue to review full report at Codecov.
|
Owner
|
That looks really promising! Great enhancement! Unfortunately my time is very limited currently. I will give it a throughout review the next days! |
Owner
|
Closed by #72 |
sgibb
added a commit
that referenced
this pull request
Nov 8, 2021
Reduced memory requirement for filterPeaks; closes #71
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I've modified the
filterPeaksfunction to use less memory. The current implementation uses a binary matrix for the peaks occurrence. I've defined a list with row, columns only, which should require less memory, if the occurrence is sparse. I've passed the tests on MacOS.