fix(messagelist): update row display immediately on flag change#11
Closed
piratefinn wants to merge 1 commit into
Closed
fix(messagelist): update row display immediately on flag change#11piratefinn wants to merge 1 commit into
piratefinn wants to merge 1 commit into
Conversation
Subscribe to messageFlagChangeSubject and update display rows directly instead of waiting for the worker round-trip. Flag changes bypass the 300ms debounce via a separate subject for immediate UI feedback. Optimistic overrides are tracked so scroll-triggered enrichRows doesn't revert them before the index data catches up. Removes the 1-second setTimeout workaround in afterUpdateIndex. 9 unit tests in searchmessagedisplay.spec.ts.
Author
|
Closing in favour of runbox#1990 which targets master directly with the root cause fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flag changes (markSeen, flag/unflag) were round-tripping through the Xapian worker before the display updated. The Angular 16 upgrade (50b8e5d) shifted timing enough to make the delay visible — click a message, row stays bold until you click another one.
Now subscribes to messageFlagChangeSubject and updates display rows directly, bypassing the worker round-trip. Flag changes go through a separate non-debounced subject so the update is immediate. Optimistic overrides are tracked so enrichRows (scroll-triggered) doesn't revert them before the index data catches up.
Removes the 1-second setTimeout workaround in afterUpdateIndex.
9 unit tests in searchmessagedisplay.spec.ts.