Fix adiabatic BC corner overwrites in natural convection test#177
Merged
Fix adiabatic BC corner overwrites in natural convection test#177
Conversation
Adiabatic top/bottom wall BCs were overwriting corner cells that belong to the hot/cold Dirichlet sidewalls. Restrict adiabatic Neumann copies to interior columns (i=1..nx-2) so sidewall temperatures are preserved at corners.
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a boundary-condition ordering/coverage issue in the natural convection validation test so adiabatic (Neumann) top/bottom temperature updates no longer overwrite the hot/cold Dirichlet corner cells.
Changes:
- Restricts adiabatic top/bottom wall temperature copies to interior columns (
i = 1 .. nx-2). - Preserves left/right wall (hot/cold) corner temperatures by avoiding updates at
i=0andi=nx-1.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adiabatic top/bottom wall BCs were overwriting corner cells that belong to the hot/cold Dirichlet sidewalls. Restrict adiabatic Neumann copies to interior columns (i=1..nx-2) so sidewall temperatures are preserved at corners.