-
Notifications
You must be signed in to change notification settings - Fork 0
docs: Complete Phase 7 - documentation and examples #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
bbf7e64
docs: Complete Phase 7 - documentation and examples
shaia c3b6df9
refactor(examples): Clean up channel_flow.py
shaia 3a39100
fix(examples): Prevent division by zero in lid_driven_cavity_advanced
shaia dd7e1b4
style(examples): Use consistent import style for cfd_python
shaia 19473b1
docs: Update CHANGELOG with all migration phases and fix import style
shaia 7fb3ec4
fix(examples): Correct comment/code mismatch in error_handling.py
shaia bfde1a0
docs(examples): Clarify code behavior in channel_flow and error_handling
shaia 1e68816
refactor: Use explicit MRO filtering instead of slice
shaia 5101082
docs: Clarify Poiseuille flow formula in channel_flow example
shaia 5a61b7e
style: Use consistent import style in test_errors.py
shaia c3e0e25
fix: Use simulation results for statistics in channel_flow example
shaia d2665ea
style: Use OSError consistently instead of IOError
shaia 607b578
docs: Clarify synthetic fields in derived_fields.py example
shaia 255dd5f
docs: Fix misleading no-slip BC comment in channel_flow.py
shaia a4e5858
fix: Correct exception constructor parameter order in error_handling.py
shaia 732e775
fix: Fix example scripts for cross-platform compatibility
shaia 8f39580
feat: Add matplotlib visualization example
shaia cb73ed6
refactor: Write all example outputs to examples/output/ directory
shaia 8ec62d0
docs: Add Rankine vortex explanation to visualization example
shaia 1a4d434
docs: Add physics explanations to all example files
shaia 40db79c
fix: Correct lid_driven_cavity_advanced convergence tracking
shaia 05dfb46
docs: Add missing examples to examples/README.md
shaia File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -154,6 +154,10 @@ src/cfd_lib/ | |
| *.vtu | ||
| *.pvd | ||
|
|
||
| # Example output files | ||
| examples/output/ | ||
| *.csv | ||
|
|
||
| # IDE | ||
| .vscode/ | ||
| .idea/ | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The MIGRATION_PLAN.md lists only 4 examples in Phase 7.4 (boundary_conditions.py, backend_detection.py, derived_fields.py, error_handling.py), but the PR description mentions 8 examples total, including channel_flow.py, lid_driven_cavity_advanced.py, solver_comparison.py, and vtk_output.py. The migration plan should be updated to include all examples that were actually added.