Skip to content

Update DISTRIBUTION.md to reflect current CI/CD setup#8

Merged
shaia merged 3 commits intomasterfrom
docs/update-distribution-guide
Dec 2, 2025
Merged

Update DISTRIBUTION.md to reflect current CI/CD setup#8
shaia merged 3 commits intomasterfrom
docs/update-distribution-guide

Conversation

@shaia
Copy link
Copy Markdown
Owner

@shaia shaia commented Dec 1, 2025

  • Document stable ABI configuration (CFD_USE_STABLE_ABI, wheel.py-api)
  • Replace outdated cibuildwheel docs with current pip wheel approach
  • Document build-wheels.yml reusable workflow
  • Document publish.yml with trusted publishing (OIDC)
  • Add trusted publishing setup instructions
  • Update action versions (v3 -> v4)

- Document stable ABI configuration (CFD_USE_STABLE_ABI, wheel.py-api)
- Replace outdated cibuildwheel docs with current pip wheel approach
- Document build-wheels.yml reusable workflow
- Document publish.yml with trusted publishing (OIDC)
- Add trusted publishing setup instructions
- Update action versions (v3 -> v4)
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the DISTRIBUTION.md documentation to accurately reflect the current CI/CD setup, replacing outdated cibuildwheel references with the current pip wheel approach and documenting the new trusted publishing workflow.

Key changes:

  • Documents stable ABI configuration (CFD_USE_STABLE_ABI option and wheel.py-api setting) for building cross-version compatible wheels
  • Replaces cibuildwheel documentation with current pip wheel approach used in CI
  • Documents the reusable build-wheels.yml workflow and new publish.yml workflow with OIDC trusted publishing

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

- Fix CFD_USE_STABLE_ABI default value (ON not OFF)
- Add platform-specific CFD library build steps (Unix needs -DCMAKE_POSITION_INDEPENDENT_CODE=ON)
- Add complete artifact download steps with patterns and validation
- Fix publish_pypi conditional to include workflow_dispatch target
- Pin pypa/gh-action-pypi-publish to SHA to prevent supply-chain attacks
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 10 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

CI/CD workflows are self-documenting with comments.
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

@shaia shaia merged commit 767cd8f into master Dec 2, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants