fix: update Node to 20.x and upgrade npm for trusted publishing#455
Merged
fix: update Node to 20.x and upgrade npm for trusted publishing#455
Conversation
Node 16 ships with npm 8.x which doesn't support npm trusted publishing (OIDC provenance), requiring npm 9.5+. This updates the GitHub Action to use actions/setup-node@v4 with Node 20.x and adds an npm upgrade step, matching the pattern already used in .github/workflows/maven.yml. https://claude.ai/code/session_013qz1NYPTSvpAWsjdDXZqLk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
actions/setup-nodefrom v2 to v4 and Node from 16.x to 20.x in the GitHub Action (action.yml)npm install -g npm@lateststep after Node setup to ensure npm supports trusted publishing (OIDC provenance requires npm 9.5+)deploy_target: npmworkflows that rely on OIDC provenanceThis matches the pattern already used in jDeploy's own CI workflow (
.github/workflows/maven.ymllines 33-38).Test plan
deploy_target: githubdeploy_target: npmusing trusted publishing (OIDC)--provenance)https://claude.ai/code/session_013qz1NYPTSvpAWsjdDXZqLk