bugfix

[jirikapoun]

fixed links not being generated properly when option result_list_use_geturl switched on

[shannah]

Can you describe the scenario that failed, requiring this fix? When result_list_use_geturl is on, it should just link to the "view" action for the record, which is what the original version did. What did this change accomplish for you?

[jirikapoun]

Hello,

it is possible that I misunderstood the purpose of this option. I thought
it is there just to make it possible to modify the behavior using getURL
delegate method - when this option is off, this method is not taken into
account at all.

In my particular scenario, I wanted to keep everything exactly as it is,
except one thing - change 'default_browse_action' for one particular table
from 'edit' to 'view'. Therefore I wrote this delegate class:

getURL($params); } }}?>

At first, Xataface did not pay any attention to the delegate method at all.
After a while of researching, I discovered the 'result_list_use_geturl'
option, so I turned it on. But then there was another problem - Xataface
ignored 'default_browse_action' option and always used 'view' action. So I
dove into the source code and found the cause - and, considering it a bug,
comitted a "bugfix" afterwards.

What I considered to be a bug might be no bug at all, it might even be an
intended feature. If so, I would really appreciate if you clarified me what
is the purpose of the 'view' action being hard-coded there when this option
is on. It is not unlikely it is because of something I am totally unaware
of, so your explanation would help me to comprehend Xataface better.

PS: Keep up the good work! I use Xataface a lot at work. Database
application development would be a pain without it.

On 07/14/2016 05:58 PM, Steve Hannah wrote:

Can you describe the scenario that failed, requiring this fix? When
result_list_use_geturl is on, it should just link to the "view" action for
the record, which is what the original version did. What did this change
accomplish for you?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#75 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/ASsKiWmS-mrcNieiI5rOFi9NSGp-L7Qkks5qVlyngaJpZM4JMd1O
.