Fix E2E tests to match wabi-sabi Japanese auth UI#5
Merged
Conversation
The auth redesign changed all labels/buttons to Japanese and removed
input placeholders, which broke every Playwright spec (all specs log in
through the auth page). Update selectors accordingly:
- getByPlaceholder('Email'/'Password') -> getByLabel('メール'/'パスワード')
- 'Sign in' -> 'ログイン', 'Sign up'/'Create account' -> '新規登録'
- Add aria-label to the auth inputs so getByLabel is stable (no visual
change; the label text was previously not programmatically associated).
All 20 tests pass locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The auth redesign changed all labels/buttons to Japanese and removed input placeholders, which broke every Playwright spec (all specs log in through the auth page). Update selectors accordingly: