Skip to content

Fix HTML tag for Basis Universal in index.html#21

Merged
sharjith merged 1 commit intomasterfrom
sharjith-patch-1
Mar 11, 2026
Merged

Fix HTML tag for Basis Universal in index.html#21
sharjith merged 1 commit intomasterfrom
sharjith-patch-1

Conversation

@sharjith
Copy link
Copy Markdown
Owner

@sharjith sharjith commented Mar 11, 2026

Pull Request

Thanks for contributing to ModelViewer! Please fill in the details below to help us understand and review your changes.


Description

What changes do you make? Provide a clear summary of your modifications.


Type of Change

What kind of change is this?

  • 🐛 Bug fix (fixes an existing issue)
  • ✨ New feature (adds new functionality)
  • 📚 Documentation (updates docs, README, comments)
  • 🎨 Code style (formatting, cleanup, no logic changes)
  • ♻️ Refactoring (code reorganization, no feature/bug changes)
  • ⚡ Performance improvement (optimization)
  • 🧪 Test (adding or updating tests)
  • 🔧 Build/dependencies (CMake, package updates, etc.)

Related Issues

Does this PR fix or relate to any GitHub issues?

Closes #123
Related to #456


Motivation & Context

Why are these changes needed? What problem do they solve?


How Has This Been Tested?

How did you test these changes? Please be specific.

Test Cases:

  • Tested with glTF 2.1 models
  • Tested with STEP files with assemblies
  • Tested on Linux
  • Tested on Windows
  • Tested on macOS
  • Tested with large models (100+ MB)
  • Other: ________________

Steps to Reproduce/Verify:


Screenshots / Video (if applicable)

Before & After (for visual changes):

Before:
After:


Checklist

Please verify your PR meets these requirements:

  • My code follows the project's style guidelines
  • I have performed a self-review of my code
  • I have commented my code, especially complex sections
  • My changes generate no new compiler warnings
  • I have added/updated tests for my changes (if applicable)
  • New dependencies are documented in README.md
  • I have updated relevant documentation
  • I have tested on multiple platforms (if applicable)
  • I have verified no performance regressions

Breaking Changes?

Does this PR introduce breaking changes?

  • No, this is a backwards-compatible change
  • Yes, this breaks existing functionality:

Additional Notes / Comments

Any other information reviewers should know?

  • Known limitations or TODOs
  • Future improvements planned
  • Dependencies on other PRs
  • Performance considerations

Related Documentation / References

Links to relevant documentation, specifications, or references:


Thank you for your contribution! 🙌

Once submitted, your PR will be:

  1. Reviewed for code quality and functionality
  2. Tested on multiple platforms
  3. Discussed if changes are needed
  4. Merged when approved!

If you have any questions, feel free to ask in the comments. We're here to help! 💬

@sharjith sharjith merged commit 210672d into master Mar 11, 2026
0 of 6 checks passed
@sharjith sharjith deleted the sharjith-patch-1 branch March 11, 2026 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant