Fix web build: broaden isDeleteQueued type guard#78
Merged
Conversation
The file-delete mutation returns FileDeleted | DeleteQueued, but isDeleteQueued only accepted DeleteResult (void | DeleteQueued), so uploaded-files-card failed to type-check under tsc -b (FileDeleted not assignable to DeleteResult), breaking the web build. Widen the guard's parameter to unknown; it already narrows via the pending_action_id check, and all existing DeleteResult callers still work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mainis red: the web build (tsc -b) fails since #76 merged.The file-delete mutation returns
FileDeleted | DeleteQueued, butisDeleteQueuedonly acceptedDeleteResult(void | DeleteQueued), soFileDeletedisn't assignable. Widen the guard's parameter tounknown- it already narrows via thepending_action_idcheck, and every existingDeleteResultcaller still type-checks.Why it slipped through
The local check script runs
tsc --noEmit, which doesn't fully resolve project references the way CI'stsc -bdoes, so it didn't surface the error. Verified this fix withtsc -b,eslint, and a fullnpm run build(all green).Migrations
None.