Show Re-issue activation link for mobile_push channels too#82
Merged
Conversation
The Re-issue button on the channel detail page only appeared for web_push, so mobile_push channels in pending_registration (notably ones restored by re-import, where the original activation hash/expiry deliberately doesn't ride along) had no way to get a fresh magic link. The backend reissue endpoint already accepts any push type; the frontend gate just needed to match. Same fix covers the consumed-but- unfinished case where the channel stays pending after a redeem half- completes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Re-issue button on the channel detail page was gated on
destination_type === "web_push", somobile_pushchannels inpending_registrationhad no UI path to a fresh magic link. That breaks the two cases noted in load testing:pending_registrationwith no link.pending_registration.Backend (
POST /v1/channels/{id}/reissue-activation) already accepts any push type (_PUSH_TYPES = {web_push, mobile_push}); only the frontend gate needed widening. One-line condition change.ruff / tsc / eslint clean. Frontend only.