Skip to content

chore(ui): remove custom fields column from device list#6385

Merged
gustavosbarreto merged 1 commit into
masterfrom
chore/remove-custom-fields-column
May 28, 2026
Merged

chore(ui): remove custom fields column from device list#6385
gustavosbarreto merged 1 commit into
masterfrom
chore/remove-custom-fields-column

Conversation

@gustavosbarreto
Copy link
Copy Markdown
Member

Summary

  • Removes the "Custom Fields" column from the device listing on the React console.
  • Affects all status tabs (accepted, pending, rejected) since they share baseColumns.

@gustavosbarreto gustavosbarreto requested a review from a team as a code owner May 28, 2026 14:30
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 28, 2026

Claude finished @gustavosbarreto's task in 1m 4s —— View job


Code Review Complete

Reviewed 1 file across code quality, security, testing, language patterns, and architecture — 1 issue found (high severity).

Tests will fail: leftover assertions for removed "Custom Fields" column

The test file ui-react/apps/console/src/pages/devices/__tests__/Devices.test.tsx still contains tests that assert on the removed column's rendered output. These tests will fail on CI:

  1. Lines 228-238'renders the "Custom Fields" column header' calls screen.getByRole("columnheader", { name: "Custom Fields" }), which will throw since the column header no longer renders.

  2. Lines 287-327 — The entire describe("custom fields column") block (3 tests) asserts on elements ("—", "env", "production", etc.) that were exclusively rendered by the now-removed column.

Both should be deleted to keep the test suite passing.

Fix this →


To request another review round, comment /review.

@gustavosbarreto gustavosbarreto force-pushed the chore/remove-custom-fields-column branch from 73b1768 to 4382682 Compare May 28, 2026 14:36
@gustavosbarreto
Copy link
Copy Markdown
Member Author

/review

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 28, 2026

Claude finished @gustavosbarreto's task in 11s —— View job


Code Review Complete

Reviewed 2 files across code quality, security, testing, language patterns, and architecture — no issues found. The code looks good as-is.


To request another review round, comment /review.

@gustavosbarreto gustavosbarreto merged commit 9b6177c into master May 28, 2026
12 checks passed
@gustavosbarreto gustavosbarreto deleted the chore/remove-custom-fields-column branch May 28, 2026 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant