fix(docker): pass web endpoints envs to enterprise api service#6394
Merged
Conversation
The api-enterprise service registers the web endpoint and legacy tunnel routes, gated by SHELLHUB_WEB_ENDPOINTS. The unified architecture merge dropped the cloud service that carried these envs, and the later overlay fix added them to gateway/ssh/ui but missed api. Without them the api never enables the feature, so every web endpoint and tunnel request returns 404 in enterprise deployments even with the flag set elsewhere. Fixes: #6393
|
Claude finished @gustavosbarreto's task in 3m 5s —— View job Code Review CompleteReviewed 1 file across code quality, security, testing, Go/TypeScript patterns, and architecture — no issues found. The code looks good as-is. The fix correctly adds the missing To request another review round, comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
SHELLHUB_WEB_ENDPOINTSandSHELLHUB_WEB_ENDPOINTS_DOMAINto theapi(api-enterprise) service indocker-compose.enterprise.yml.Why
In the unified architecture the cloud/enterprise routes are registered inside the
api-enterprisebinary, gated bySHELLHUB_WEB_ENDPOINTS. The web-endpoints envs used to live on the separatecloudservice; commit782f93e63removed that service when merging intoapi-enterprisebut did not carry the envs ontoapi, and the later overlay fix47599e316added them to gateway/ssh/ui but missedapi.Without them the api never enables the feature, so in enterprise deployments (
SHELLHUB_ENTERPRISE=true,SHELLHUB_CLOUD=false) every web endpoint and legacy tunnel request returns 404, even with the flag set on the other services. The gateway renders the routes and the subdomain proxy, forwards toapi:8080, and the api 404s because the handlers were never registered.The DNS provider / ACME vars are consumed only by the gateway, so they are not added here.
Affects v0.25.0-rc.1 and current master.
Fixes: #6393