fix(ui-react): cap namespace selector list height to prevent overflow#6399
Merged
gustavosbarreto merged 1 commit intoJun 1, 2026
Merged
Conversation
With many namespaces the dropdown grew past the viewport and broke the page layout. Constrain the list to a max height and scroll it instead.
|
Claude finished @luizhf42's task in 1m 43s —— View job Code Review CompleteReviewed 1 file across code quality, security, testing, language patterns, and architecture — no issues found. The code looks good as-is. The change correctly applies If you push additional changes and want a new review, tag |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The namespace selector dropdown now caps its namespace list at a fixed height and scrolls internally instead of growing unbounded.
Why
With a large number of namespaces, the list grew taller than the viewport, pushing the dropdown past the body height and breaking the page layout.
Changes
max-h-72 overflow-y-autoto the namespace list container so only the list scrolls while the active-namespace header and the Create/Admin footers stay pinned. This matches the existing scroll pattern used byInvitationsMenu(max-h-[360px] overflow-y-auto) andPendingDevices(max-h-[280px] overflow-y-auto).Testing
Open the selector in an account with enough namespaces to exceed
~5rows and confirm the list scrolls within the dropdown, the header and footer stay fixed, and the dropdown no longer overflows the viewport.