Skip to content

feat(daemon): update service descriptors for systemd and launchctl #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AnnatarHe merged 1 commit into from
Oct 5, 2025
Merged

feat(daemon): update service descriptors for systemd and launchctl #130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion model/sys-desc/shelltime.service
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,15 @@ After=network.target

[Service]
Type=simple
ExecStart=/usr/local/bin/shelltime-daemon
ExecStart=/bin/sh -c 'exec $(getent passwd username | cut -d: -f7) -l -c "/usr/local/bin/shelltime-daemon"'
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Oct 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The ExecStart command has two issues that will prevent the service from running correctly:

  1. Hardcoded username: The username is hardcoded as username. This will cause getent passwd username to fail for any user whose login is not 'username'. This should be replaced with the template variable {{.UserName}}.

  2. Hardcoded executable path: The path to shelltime-daemon is hardcoded to /usr/local/bin/shelltime-daemon. The installer logic places the binary at a path constructed from BaseFolder. This path should also be templated, e.g., {{.BaseFolder}}/bin/shelltime-daemon, just like in the macOS .plist file.

Fixing this will also require updating model/daemon-installer.linux.go to pass the BaseFolder variable to the template.

ExecStart=/bin/sh -c 'exec $(getent passwd {{.UserName}} | cut -d: -f7) -l -c "{{.BaseFolder}}/bin/shelltime-daemon"'

Restart=always

# Resource limits
LimitNOFILE=65536

# Logging
StandardOutput=journal
StandardError=journal

[Install]
WantedBy=default.target
4 changes: 3 additions & 1 deletion model/sys-desc/xyz.shelltime.daemon.plist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,9 @@
<string>xyz.shelltime.daemon</string>
<key>ProgramArguments</key>
<array>
<string>{{.BaseFolder}}/bin/shelltime-daemon</string>
<string>/bin/sh</string>
<string>-c</string>
<string>exec $SHELL -l -c '{{.BaseFolder}}/bin/shelltime-daemon'</string>
</array>
<key>RunAtLoad</key>
<true/>
Expand Down