Skip to content

fix(daemon): use gui domain instead of deprecated user domain for launchctl#135

Merged
AnnatarHe merged 1 commit intomainfrom
fix/daemon-use-gui-domain-for-launchctl
Oct 7, 2025
Merged

fix(daemon): use gui domain instead of deprecated user domain for launchctl#135
AnnatarHe merged 1 commit intomainfrom
fix/daemon-use-gui-domain-for-launchctl

Conversation

@AnnatarHe
Copy link
Copy Markdown
Contributor

Summary

  • Fixed daemon status check on macOS to use gui domain instead of deprecated user domain
  • Changed from user/501 to gui/501 when running launchctl print command

Problem

The launchctl print user/501/xyz.shelltime.daemon command was failing to find the running daemon service, even though the process was visible in Activity Monitor. This is because the user domain is deprecated in modern macOS versions.

Solution

LaunchAgents in ~/Library/LaunchAgents/ run in the gui domain by default, not the user domain. Updated the Check() method in daemon-installer.darwin.go to use the correct domain.

Test plan

  • Install daemon on macOS: shelltime daemon install
  • Verify daemon status check works: shelltime daemon status
  • Confirm launchctl print gui/501/xyz.shelltime.daemon returns service info

🤖 Generated with Claude Code

…nchctl

Changed from user/501 to gui/501 domain when checking daemon service status.
The user domain is deprecated in modern macOS versions, and LaunchAgents in
~/Library/LaunchAgents/ run in the gui domain by default.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @AnnatarHe, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a critical issue on macOS where the application's daemon status could not be reliably checked. The problem stemmed from using a deprecated user domain with the launchctl print command. The fix updates this command to correctly utilize the gui domain, which is the appropriate context for LaunchAgents, thereby enabling accurate status reporting and improving the application's diagnostic capabilities on macOS.

Highlights

  • macOS Daemon Status Fix: The daemon status check on macOS has been fixed to correctly identify running services, resolving an issue where the daemon was running but its status could not be retrieved.
  • Updated launchctl Domain: The launchctl print command now uses the gui domain instead of the deprecated user domain, aligning with modern macOS practices for LaunchAgents and ensuring accurate daemon detection.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 7, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
model/daemon-installer.darwin.go 0.00% 1 Missing ⚠️
Flag Coverage Δ
unittests 23.56% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
model/daemon-installer.darwin.go 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Warning

Gemini encountered an error creating the review. You can try again by commenting /gemini review.

@AnnatarHe AnnatarHe merged commit 2381253 into main Oct 7, 2025
2 of 3 checks passed
@AnnatarHe AnnatarHe deleted the fix/daemon-use-gui-domain-for-launchctl branch October 7, 2025 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant