Skip to content

refactor(otel): remove unused SendCCSessionEnd function and types#145

Merged
AnnatarHe merged 2 commits intomainfrom
refactor/remove-unused-session-end-api
Dec 16, 2025
Merged

refactor(otel): remove unused SendCCSessionEnd function and types#145
AnnatarHe merged 2 commits intomainfrom
refactor/remove-unused-session-end-api

Conversation

@AnnatarHe
Copy link
Copy Markdown
Contributor

Summary

  • Remove unused SendCCSessionEnd function from model/api_ccotel.go
  • Remove unused CCSessionEndRequest and CCSessionEndResponse types from model/ccotel_types.go

Test plan

  • Verified go build ./... succeeds

🤖 Generated with Claude Code

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @AnnatarHe, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on code hygiene by removing unused functions and type definitions related to OpenTelemetry session ending. This refactoring effort aims to reduce technical debt, improve code readability, and simplify the codebase by eliminating dead code that no longer serves a purpose.

Highlights

  • Code Removal: The SendCCSessionEnd function, previously located in model/api_ccotel.go, has been entirely removed as it was identified as unused.
  • Type Definition Cleanup: The CCSessionEndRequest and CCSessionEndResponse type definitions, found in model/ccotel_types.go, have been removed due to their lack of usage within the codebase.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the unused SendCCSessionEnd function from model/api_ccotel.go and the associated CCSessionEndRequest and CCSessionEndResponse types from model/ccotel_types.go. This is a good refactoring that improves code maintainability by removing dead code. The changes are clean and I found no issues. Great work on keeping the codebase tidy.

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 16, 2025

Codecov Report

❌ Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
daemon/ccotel_processor.go 0.00% 11 Missing ⚠️
Flag Coverage Δ
unittests 20.95% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
model/api_ccotel.go 0.00% <ø> (ø)
daemon/ccotel_processor.go 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

- Add WSLVersion field to CCOtelSession for WSL environment detection
- Add Prompt field to CCOtelEvent for capturing prompt content
- Add tool_parameters parsing logic with JSON deserialization
- Add encoding/json import for tool parameters handling

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@AnnatarHe AnnatarHe merged commit 80a5e8f into main Dec 16, 2025
2 of 3 checks passed
@AnnatarHe AnnatarHe deleted the refactor/remove-unused-session-end-api branch December 16, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant