Skip to content

feat(daemon): display CCOtel debug config in status command#164

Merged
AnnatarHe merged 1 commit intomainfrom
feat/daemon-status-show-ccotel-debug
Dec 25, 2025
Merged

feat(daemon): display CCOtel debug config in status command#164
AnnatarHe merged 1 commit intomainfrom
feat/daemon-status-show-ccotel-debug

Conversation

@AnnatarHe
Copy link
Copy Markdown
Contributor

Summary

  • Add debug flag status display to daemon status command output
  • When CCOtel is enabled, now shows: CCOtel: enabled (port 4317, debug on/off)

Test plan

  • Run shelltime daemon status with CCOtel enabled and debug on
  • Run shelltime daemon status with CCOtel enabled and debug off
  • Run shelltime daemon status with CCOtel disabled

🤖 Generated with Claude Code

Show the debug flag status (on/off) alongside port number when CCOtel
is enabled in the daemon status output.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @AnnatarHe, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the daemon status command by integrating the CCOtel debug configuration into its output. This provides users with a more comprehensive view of the daemon's operational state, specifically regarding the CCOtel service, by indicating whether its debug mode is active. The change improves observability and helps in quickly diagnosing CCOtel-related issues.

Highlights

  • Enhanced Daemon Status Output: The daemon status command now includes the debug configuration for CCOtel when it is enabled.
  • CCOtel Debug Status Display: When CCOtel is active, the status output will explicitly show whether its debug mode is 'on' or 'off', alongside its enabled status and port.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 25, 2025

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
commands/daemon.status.go 0.00% 4 Missing ⚠️
Flag Coverage Δ
unittests 20.43% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
commands/daemon.status.go 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AnnatarHe AnnatarHe merged commit 1ace77e into main Dec 25, 2025
2 of 3 checks passed
@AnnatarHe AnnatarHe deleted the feat/daemon-status-show-ccotel-debug branch December 25, 2025 15:15
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enhances the daemon status command to display the debug configuration for CCOtel. The implementation is functionally correct. I've added one suggestion regarding a repeated code pattern for checking nullable boolean flags. Consolidating this logic into a helper function could improve the overall maintainability and readability of the code, as this pattern is used in multiple places.

Comment thread commands/daemon.status.go
Comment on lines +68 to +70
if cfg.CCOtel.Debug != nil && *cfg.CCOtel.Debug {
debugStatus = "on"
}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The logic for checking the nullable boolean cfg.CCOtel.Debug is correct. However, this pattern of checking ptr != nil && *ptr is used multiple times in this file (e.g., for CCOtel.Enabled, CCOtel.Debug, and CodeTracking.Enabled). To improve code clarity and maintainability by reducing repetition, consider abstracting this logic into a helper function.

For example:

// isTrue checks if a *bool is non-nil and true.
func isTrue(b *bool) bool {
    return b != nil && *b
}

This would allow you to simplify these checks to if isTrue(cfg.CCOtel.Debug). Since this pattern is becoming more common in the codebase, introducing a helper function would be a good maintainability improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant