Conversation
Support both ccotel (deprecated) and aiCodeOtel config keys to ensure users with existing configs using the old key continue to work after upgrading. The migration happens silently at config read time. - Add deprecated CCOtel field to ShellTimeConfig with old tags - Migrate ccotel to AICodeOtel in ReadConfigFile after unmarshal - Handle deprecated field in mergeConfig for local config overrides 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Summary of ChangesHello @AnnatarHe, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a configuration key rename by implementing backward compatibility. It ensures that applications can seamlessly handle older configurations that still use the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Codecov Report❌ Patch coverage is
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Code Review
This pull request adds backward compatibility for the deprecated ccotel configuration key by migrating it to aiCodeOtel. The changes correctly handle this migration for both base and local configuration files, prioritizing the new key if both are present. The implementation is solid and aligns with the PR's goal. I've added one suggestion to refactor a small piece of logic in mergeConfig to improve code clarity and avoid modifying input parameters.
| // Migrate deprecated ccotel from local config | ||
| if local.CCOtel != nil && local.AICodeOtel == nil { | ||
| local.AICodeOtel = local.CCOtel | ||
| } | ||
| if local.AICodeOtel != nil { | ||
| base.AICodeOtel = local.AICodeOtel | ||
| } |
There was a problem hiding this comment.
The current implementation for migrating the deprecated ccotel key modifies the local config object. While this works, it's generally better to avoid side effects on input parameters. A more direct approach would be to check both aiCodeOtel and the deprecated ccotel from the local config and update base accordingly, without modifying local.
This makes the function's behavior more predictable and self-contained.
// Handle AICodeOtel from local config, with fallback to deprecated ccotel
if local.AICodeOtel != nil {
base.AICodeOtel = local.AICodeOtel
} else if local.CCOtel != nil {
base.AICodeOtel = local.CCOtel
}
Summary
ccotel→aiCodeOtelconfig key rename from Implement OpenTelemetry support for Codex #181ccotelwill continue to work seamlesslyChanges
CCOtelfield toShellTimeConfigwith oldccoteltagsccoteltoAICodeOtelinReadConfigFileafter unmarshalmergeConfigfor local config overridesBehavior
ccotelsetAICodeOtel, works ✓aiCodeOtelsetaiCodeOteltakes precedence ✓Test plan
🤖 Generated with Claude Code