Skip to content

Fix context cancellation in Anthropic usage reporting goroutine #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AnnatarHe merged 1 commit into from
Feb 26, 2026
Merged

Fix context cancellation in Anthropic usage reporting goroutine #244

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion daemon/cc_info_timer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,7 +433,12 @@ func (s *CCInfoTimerService) fetchRateLimit(ctx context.Context) {
s.rateLimitCache.mu.Unlock()

// Send usage data to server for push notification scheduling (fire-and-forget)
go s.sendAnthropicUsageToServer(ctx, usage)
// Use a separate context so the goroutine isn't canceled when the caller returns.
go func() {
bgCtx, bgCancel := context.WithTimeout(context.Background(), 10*time.Second)
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve readability and maintainability, it's best to avoid using magic numbers. Consider defining 10 * time.Second as a named constant at the package level, for example sendAnthropicUsageTimeout. This makes the purpose of the timeout clearer and easier to change in the future.

defer bgCancel()
s.sendAnthropicUsageToServer(bgCtx, usage)
}()

slog.Debug("Anthropic rate limit updated",
slog.Float64("5h", usage.FiveHourUtilization),
Expand Down