-
Notifications
You must be signed in to change notification settings - Fork 0
Add Homebrew tap distribution for ShellTime CLI #271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -136,3 +136,34 @@ notarize: | |
| key_id: "{{.Env.QUILL_NOTARY_KEY_ID}}" | ||
| key: "{{.Env.QUILL_NOTARY_KEY}}" | ||
| wait: true | ||
| brews: | ||
| - name: shelltime | ||
| ids: | ||
| - mt-common | ||
| - mac | ||
| repository: | ||
| owner: shelltime | ||
| name: homebrew-tap | ||
| token: "{{ .Env.HOMEBREW_TAP_GITHUB_TOKEN }}" | ||
| directory: Formula | ||
| homepage: "https://shelltime.xyz" | ||
| description: "Track and analyze your shell usage - ShellTime CLI" | ||
| license: "MIT" | ||
| commit_author: | ||
| name: shelltime-bot | ||
| email: bot@shelltime.xyz | ||
| install: | | ||
| bin.install "shelltime" | ||
| bin.install "shelltime-daemon" | ||
| test: | | ||
| system "#{bin}/shelltime", "--version" | ||
| caveats: | | ||
| To get started with ShellTime, run: | ||
| shelltime init | ||
|
|
||
| Or set up manually: | ||
| shelltime auth | ||
| shelltime hooks install | ||
| shelltime daemon install | ||
|
|
||
| For more info, visit https://shelltime.xyz | ||
|
Comment on lines
+139
to
+169
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🟡 README not updated with Homebrew install method, violating AGENTS.md documentation rule AGENTS.md mandates: "When command behavior, setup flow, config formats, or integrations change, update the docs in the same change." This PR adds Homebrew tap as a new installation method via Prompt for agentsWas this helpful? React with 👍 or 👎 to provide feedback. |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
shelltime initandshelltime daemon installcommands mentioned in the caveats will fail for users who install via Homebrew.The current implementation of
commandDaemonInstallincommands/daemon.install.go(lines 54-58) explicitly checks for the daemon binary at~/.shelltime/bin/shelltime-daemon. However, Homebrew installs binaries to the system PATH (e.g.,/usr/local/binor/opt/homebrew/bin).When a Homebrew user runs these commands, they will receive an error message directing them to use the
curlinstallation script, which defeats the purpose of the Homebrew distribution. You should update the CLI logic to look forshelltime-daemonin the system PATH as a fallback before checking the local directory.