Skip to content

feat: replace vmihailenco/msgpack with ugorji/go/codec#74

Closed
AnnatarHe wants to merge 2 commits intomainfrom
feat/replace-msgpack-library
Closed

feat: replace vmihailenco/msgpack with ugorji/go/codec#74
AnnatarHe wants to merge 2 commits intomainfrom
feat/replace-msgpack-library

Conversation

@AnnatarHe
Copy link
Copy Markdown
Contributor

Summary

  • Replaced github.com/vmihailenco/msgpack/v5 with a custom msgpack module using github.com/ugorji/go/codec
  • Created new model/msgpack.go with encode/decode functions
  • Updated all imports and function calls throughout the codebase
  • Changed struct tags from msgpack: to codec: for compatibility

Breaking Changes

  • Struct field tags changed from msgpack:"field" to codec:"field"
  • This may affect external systems that depend on the exact msgpack format

Test Plan

  • Added comprehensive tests for the new msgpack module
  • Ran existing tests - most pass, some handshake tests fail due to format differences
  • Manual testing of CLI commands
  • Test daemon functionality

Related Issues

Closes #[issue-number] (if applicable)

🤖 Generated with Claude Code

AnnatarHe and others added 2 commits July 2, 2025 23:34
- Created msgpack.go module with encode/decode functions using ugorji/go/codec
- Replaced all vmihailenco/msgpack imports with calls to model.Msgpack* functions
- Updated struct tags from `msgpack:` to `codec:` for compatibility
- Removed vmihailenco/msgpack dependency from go.mod
- Added comprehensive tests for the new msgpack module

BREAKING CHANGE: Struct tags changed from `msgpack:` to `codec:`

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
- Add GitHub Actions workflow for pull request checks
- Setup Go 1.24 environment
- Run tests with coverage collection
- Upload coverage to Codecov
- Cache Go modules for faster builds

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@AnnatarHe AnnatarHe closed this Dec 13, 2025
@AnnatarHe AnnatarHe deleted the feat/replace-msgpack-library branch December 13, 2025 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant