Skip to content

feat(install): rename old manual binaries to .bak after Homebrew install #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AnnatarHe merged 1 commit into from
Apr 12, 2026
Merged

feat(install): rename old manual binaries to .bak after Homebrew install #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions install.bash
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,15 @@ if [[ "$OS" == "Darwin" ]] && command_exists brew; then
if brew install shelltime/tap/shelltime; then
BREW_INSTALLED=true
echo "Successfully installed shelltime via Homebrew."
# Rename old manual-install binaries so the system uses the Homebrew version
if [ -f "$HOME/.shelltime/bin/shelltime" ]; then
mv "$HOME/.shelltime/bin/shelltime" "$HOME/.shelltime/bin/shelltime.bak"
echo "Renamed ~/.shelltime/bin/shelltime to shelltime.bak (now using Homebrew version)"
Comment on lines +29 to +30
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Apr 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Use mv -f to ensure the command does not prompt for confirmation (e.g., if the user has an alias like mv -i) and wrap it in an if block to only print the success message if the operation actually succeeds.

Suggested change
mv "$HOME/.shelltime/bin/shelltime" "$HOME/.shelltime/bin/shelltime.bak"
echo "Renamed ~/.shelltime/bin/shelltime to shelltime.bak (now using Homebrew version)"
if mv -f "$HOME/.shelltime/bin/shelltime" "$HOME/.shelltime/bin/shelltime.bak"; then
echo "Renamed ~/.shelltime/bin/shelltime to shelltime.bak (now using Homebrew version)"
fi

fi
if [ -f "$HOME/.shelltime/bin/shelltime-daemon" ]; then
mv "$HOME/.shelltime/bin/shelltime-daemon" "$HOME/.shelltime/bin/shelltime-daemon.bak"
echo "Renamed ~/.shelltime/bin/shelltime-daemon to shelltime-daemon.bak (now using Homebrew version)"
Comment on lines +33 to +34
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Apr 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Use mv -f to avoid interactive prompts and only print the success message if the command succeeds.

Suggested change
mv "$HOME/.shelltime/bin/shelltime-daemon" "$HOME/.shelltime/bin/shelltime-daemon.bak"
echo "Renamed ~/.shelltime/bin/shelltime-daemon to shelltime-daemon.bak (now using Homebrew version)"
if mv -f "$HOME/.shelltime/bin/shelltime-daemon" "$HOME/.shelltime/bin/shelltime-daemon.bak"; then
echo "Renamed ~/.shelltime/bin/shelltime-daemon to shelltime-daemon.bak (now using Homebrew version)"
fi

fi
else
echo "Homebrew installation failed. Falling back to manual installation..."
fi
Expand Down
Loading