Update GitHub organization from malamtime to shelltime#9
Conversation
- Point CLI download at github.com/shelltime/cli (was legacy malamtime/cli, which no longer resolves). Manual-install flow was 404-ing on every platform. - Point shell hook downloads at github.com/shelltime/installation (was malamtime/installation). Hooks for zsh/bash/fish failed to fetch for both manual and Homebrew paths. - Install shelltime-daemon to ~/.shelltime/bin/shelltime-daemon instead of renaming the freshly extracted binary to .bak, so `shelltime daemon reinstall` can find it.
Code ReviewOverviewThis PR does two things: (1) renames GitHub org references from URL Updates (
|
| Area | Status |
|---|---|
| Org rename (URLs) | ✅ Clean and complete |
| Daemon naming fix | ✅ Correct direction |
| Homebrew path consistency | |
Upgrade migration (orphaned .bak) |
|
| Security | ✅ No concerns |
| Tests | ✅ Existing CI sufficient |
The PR is mergeable as-is. The orphaned .bak cleanup and Homebrew-path comment are suggestions, not blockers.
Reviewed by Claude (claude-sonnet-4-6)
There was a problem hiding this comment.
Code Review
This pull request updates repository URLs from 'malamtime' to 'shelltime' and simplifies the daemon installation logic by removing backup file handling. A review comment suggests adding error handling to the daemon move command to prevent silent failures during installation.
| rm "$HOME/.shelltime/bin/shelltime-daemon.bak" | ||
| fi | ||
| mv shelltime-daemon "$HOME/.shelltime/bin/shelltime-daemon.bak" | ||
| mv shelltime-daemon "$HOME/.shelltime/bin/" |
There was a problem hiding this comment.
The mv command for the daemon binary does not handle potential failures. If the move operation fails—for instance, due to insufficient permissions or the daemon process being currently active ('Text file busy')—the installation will proceed as if successful, leaving the daemon unupdated or missing. Adding a simple error check or warning would improve the robustness of the installer, especially since the previous logic included more explicit handling (even if it was flawed).
| mv shelltime-daemon "$HOME/.shelltime/bin/" | |
| mv shelltime-daemon "$HOME/.shelltime/bin/" || echo "Warning: Failed to install shelltime-daemon." |
Summary
This PR updates all GitHub repository references from the
malamtimeorganization to theshelltimeorganization, and simplifies the daemon installation process by removing unnecessary backup file handling.Key Changes
malamtime/clitoshelltime/climalamtime/installationtoshelltime/installation(zsh, fish, and bash hooks)shelltime-daemon.bakfileshelltime-daemon) instead of.baksuffixImplementation Details
The daemon installation change moves from a backup-based approach to direct installation, which simplifies the installation process and reduces unnecessary file operations. All GitHub organization references have been consistently updated across the script to reflect the new organization name.
https://claude.ai/code/session_018m32E29p45D57CCVBs6wk8