Skip to content

Update GitHub organization from malamtime to shelltime#9

Merged
AnnatarHe merged 1 commit intomainfrom
claude/fix-install-flow-MkgM5
Apr 17, 2026
Merged

Update GitHub organization from malamtime to shelltime#9
AnnatarHe merged 1 commit intomainfrom
claude/fix-install-flow-MkgM5

Conversation

@AnnatarHe
Copy link
Copy Markdown
Contributor

@AnnatarHe AnnatarHe commented Apr 17, 2026

Summary

This PR updates all GitHub repository references from the malamtime organization to the shelltime organization, and simplifies the daemon installation process by removing unnecessary backup file handling.

Key Changes

  • Updated CLI release download URL from malamtime/cli to shelltime/cli
  • Updated installation hook URLs from malamtime/installation to shelltime/installation (zsh, fish, and bash hooks)
  • Simplified daemon installation by removing the backup file creation logic:
    • Removed check for existing shelltime-daemon.bak file
    • Removed deletion of backup file
    • Changed daemon installation to use standard naming (shelltime-daemon) instead of .bak suffix

Implementation Details

The daemon installation change moves from a backup-based approach to direct installation, which simplifies the installation process and reduces unnecessary file operations. All GitHub organization references have been consistently updated across the script to reflect the new organization name.

https://claude.ai/code/session_018m32E29p45D57CCVBs6wk8


Open with Devin

- Point CLI download at github.com/shelltime/cli (was legacy malamtime/cli,
  which no longer resolves). Manual-install flow was 404-ing on every platform.
- Point shell hook downloads at github.com/shelltime/installation (was
  malamtime/installation). Hooks for zsh/bash/fish failed to fetch for both
  manual and Homebrew paths.
- Install shelltime-daemon to ~/.shelltime/bin/shelltime-daemon instead of
  renaming the freshly extracted binary to .bak, so `shelltime daemon
  reinstall` can find it.
@claude
Copy link
Copy Markdown

claude Bot commented Apr 17, 2026

Code Review

Overview

This PR does two things: (1) renames GitHub org references from malamtime to shelltime, and (2) simplifies daemon installation by removing the .bak-suffix naming convention. Both are reasonable changes, but the daemon change has a consistency issue worth addressing.


URL Updates (malamtimeshelltime)

No issues. All four references (CLI download URL + 3 hook URLs) are updated consistently. Straightforward and correct.


Daemon Installation Change

What changed:

  • Before: downloaded daemon was moved as ~/.shelltime/bin/shelltime-daemon.bak
  • After: downloaded daemon is moved as ~/.shelltime/bin/shelltime-daemon

This is an improvement — installing a primary binary with a .bak suffix was confusing. However:

Issue — Inconsistency with Homebrew path:
The Homebrew branch (lines 32–34) still renames the existing shelltime-daemonshelltime-daemon.bak when switching to Homebrew. After this PR, non-Homebrew installs will produce shelltime-daemon, but that rename-to-bak logic in the Homebrew path references a file that now has a different origin story. It's not broken, but the asymmetry is worth a comment or cleanup.

# install.bash ~line 32 (unchanged by this PR, but now contextually confusing)
mv "$HOME/.shelltime/bin/shelltime-daemon" "$HOME/.shelltime/bin/shelltime-daemon.bak"

Minor — No migration for existing .bak installs:
Users upgrading from the old installation will have an orphaned ~/.shelltime/bin/shelltime-daemon.bak that is never cleaned up. Consider adding a one-time cleanup similar to the check_and_delete_bak pattern already used for hook files:

# After the mv shelltime-daemon line:
if [ -f "$HOME/.shelltime/bin/shelltime-daemon.bak" ]; then
    rm "$HOME/.shelltime/bin/shelltime-daemon.bak"
fi

Minor — Silent overwrite on upgrade:
mv shelltime-daemon "$HOME/.shelltime/bin/" will silently overwrite an existing binary. This is standard behavior and generally fine on Linux/macOS (safe for running processes due to inode semantics), but worth being aware of. No action required.


Security

No concerns. URLs point to the correct shelltime org which is the owner of this repo. The bash-preexec.sh still downloads from the upstream rcaloras repo — correct and unchanged.


Test Coverage

No test changes included, which is acceptable given the CI only verifies end-to-end installation success. The daemon binary placement (~/.shelltime/bin/shelltime-daemon vs .bak) is not explicitly asserted in CI, so both old and new behavior would pass.


Summary

Area Status
Org rename (URLs) ✅ Clean and complete
Daemon naming fix ✅ Correct direction
Homebrew path consistency ⚠️ Minor inconsistency
Upgrade migration (orphaned .bak) ⚠️ Nice-to-have cleanup
Security ✅ No concerns
Tests ✅ Existing CI sufficient

The PR is mergeable as-is. The orphaned .bak cleanup and Homebrew-path comment are suggestions, not blockers.


Reviewed by Claude (claude-sonnet-4-6)

Copy link
Copy Markdown

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 3 additional findings.

Open in Devin Review

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates repository URLs from 'malamtime' to 'shelltime' and simplifies the daemon installation logic by removing backup file handling. A review comment suggests adding error handling to the daemon move command to prevent silent failures during installation.

Comment thread install.bash
rm "$HOME/.shelltime/bin/shelltime-daemon.bak"
fi
mv shelltime-daemon "$HOME/.shelltime/bin/shelltime-daemon.bak"
mv shelltime-daemon "$HOME/.shelltime/bin/"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The mv command for the daemon binary does not handle potential failures. If the move operation fails—for instance, due to insufficient permissions or the daemon process being currently active ('Text file busy')—the installation will proceed as if successful, leaving the daemon unupdated or missing. Adding a simple error check or warning would improve the robustness of the installer, especially since the previous logic included more explicit handling (even if it was flawed).

Suggested change
mv shelltime-daemon "$HOME/.shelltime/bin/"
mv shelltime-daemon "$HOME/.shelltime/bin/" || echo "Warning: Failed to install shelltime-daemon."

@AnnatarHe AnnatarHe merged commit 36a09e9 into main Apr 17, 2026
5 of 10 checks passed
@AnnatarHe AnnatarHe deleted the claude/fix-install-flow-MkgM5 branch April 17, 2026 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants