syntax: simplify most literal index expressions within arithmetic#1
Open
scop wants to merge 1 commit into
Open
syntax: simplify most literal index expressions within arithmetic#1scop wants to merge 1 commit into
scop wants to merge 1 commit into
Conversation
Exclude known problematic/unportable cases involving `*` and `@` instead of all index expressions. See commit 9c62772 for more info.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exclude known problematic/unportable cases involving
*and@instead of all index expressions.To me, skipping simplifications of all index expressions within arithmetic because there are a few cases where it cannot be done is somewhat unfortunate. I believe the problematic cases are rare in practice, because expressions such as
${!a[*]},${#a[*]}where*and@are commonly present are already (and need to be) skipped due to other reasons besides what's in the index.