feat: add queue timeout and wire event-driven categorization#7
Merged
Conversation
- Add 30-minute timeout to MessageQueueService to prevent permanent queue blocking when users ignore categorization notifications - Clean up pending merchant registry on timeout to invalidate stale Telegram inline buttons - Guard completeTask() against late completions from timed-out tasks - Add removePendingMerchantByMerchantId() for timeout cleanup path Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Task 006 (final task) of the grammY migration plan. Wire the event-driven categorization flow and add queue timeout to prevent permanent blocking.
Approach
The event → notification → conversation wiring was mostly done in Task 005. This task adds the missing timeout mechanism and fixes edge cases around late task completions.
Changes
message-queue.service.ts— add 30-minute task timeout with auto-completion, guard against late completions, clean up merchant registry on timeouttelegram.adapter.ts— addremovePendingMerchantByMerchantId()for timeout cleanup pathTesting
39 tests pass (7 suites).
Code Review